compiling Kalles Fraktaler with mingw

[claude]

Crash-bug solved
I have also found that there are some issues entering location parameters manually in the location dialog (Ctrl+L)
In particular the "easy deep zoom test", e.g. Re:-1.97, Im:0, Zoom:1e100

Great that the crash is fixed.

I guess that problem is because the precision for re/im (and thus the view bounds, and reference too probably) is set based on re/im string length instead of being based on zoom depth as it should be - I don't know an easy fix, mainly because I don't know where all the places that view parameter strings are converted to view parameter bigfloats.

[Kalles Fraktaler]

Great that the crash is fixed.

I guess that problem is because the precision for re/im (and thus the view bounds, and reference too probably) is set based on re/im string length instead of being based on zoom depth as it should be - I don't know an easy fix, mainly because I don't know where all the places that view parameter strings are converted to view parameter bigfloats.

I used to set the precision in the SetPosition function, I think only the one with string parameters is important for precision
1. Check if there is an 'E' or 'e' - if it is, get the number of needed decimals from the followed number (plus some value)
2. Else, check if there is a dot, if it is, use the length to the dot as the needed decimals (plus some value)
3. Else, use the total string length
SetPosition with CFixedFloat input is used only when resetting to zoom=1, or the hidden function (Ctrl+V) that takes parameters from earlier programs I've made, which can be ignored.

[knighty]

I downloaded and installed MSYS2, but then what? There is a file called msys-gmp-10.dll but no gmp.h or any .lib files...

Follow the instructions on that site. 
The installer installs only msys2. You will need to install mingw (32 or 64 or both) and the libraries by invoking pacman from MSys2 shell (as shown in the web page).

[knighty]

Finally, I've managed to compile it using Msys2/mingw64/gcc. The process was not straightforward as I expected though. I had a 2 years old msys2 installation with mingw. At the time mingw64 was installed just by following the instructions. It is not the case any more. I also couldn't compile fraktal-sft64 with it, maybe because of mingw headers issues (the compiler said so  ).

So here is what I did (windows 7 OS):

1- remove the old Msys2.
2- Uploaded latest version of msys2 (msys2-x86_64-20161025.exe). This is the 64 bit version. msys2-i686-20161025.exe is the 32 bit version.
3- after running it, it installs msys2. At the end the msys2 shell is launched.
4- In the msys2 shell, invoke pacman:

Code:

pacman -Syuu

This have to be done until is says there is nothing to do anymore.
5- close the msys2 shell:

Code:

exit

6- reopen msys2 shell (from startup menu).
7- Install mingw/gcc 64 bit:

Code:

pacman -S mingw-w64-x86_64-toolchain

(one can also install 32 bit version by: pacman -S mingw-w64-i686-toolchain)
8- close msys2 shell then open "msys2 mingw 64 bit" shell (in order to have all the environment variables properly set)
9- change directory to the kalles fraktaler sources (where Makefile resides).
10- I had to modify Makefile:
line:

Code:

WINDRES := x86_64-w64-mingw32-windres

to:

Code:

WINDRES := windres

11- compile:

Code:

mingw32-make

voila!

On my PC I have to execute it this way from (msys2 mingw 64 bit) command line:

Code:

./fraktal_sft64

because it is linked dynamically to libwinpthread-1.dll. Copying this dll next to executable will make it run from the explorer.

 

[claude]

I used to set the precision in the SetPosition function, I think only the one with string parameters is important for precision

After this changeset the "easy deep zoom test" works now:
https://code.mathr.co.uk/kalles-fraktaler-2/commitdiff/ab17330796f2698774292ec515268c2e0dfb3325

Still trying to track down the bug about losing precision when zooming manually past e38 or so.  Where in the code do the coordinates get updated by mouse wheel zoom?  I tried inserting precision-increasing code in various places but no joy so far...

knighty I guess you compiled the 'claude' branch, any chance of instructions for the 'claude-gmp' branch too?  You need boost for the multiprecision wrappers (header-only afaik, at least I don't think I compiled boost) and GMP.  I'll update the Makefile to make it possible to set the windres program from the command line without editing.

[Kalles Fraktaler]

Still trying to track down the bug about losing precision when zooming manually past e38 or so.  Where in the code do the coordinates get updated by mouse wheel zoom?  I tried inserting precision-increasing code in various places but no joy so far...

All manual zooming pass the CFraktalSFT::Zoom function.
However the actual precision controlling function is CFixedFloat::SetMaxSignificant and that is only setting the precision, globally, for the CFixedFloat class.
I always used full precision for CDecNumber (except for Newton-Raphson)

[claude]

All manual zooming pass the CFraktalSFT::Zoom function.
However the actual precision controlling function is CFixedFloat::SetMaxSignificant and that is only setting the precision, globally, for the CFixedFloat class.
I always used full precision for CDecNumber (except for Newton-Raphson)

Good to know.  The fact that you used full precision for CDecNumber makes it more difficult to adapt the code, now that I removed the maximum precision limit.

In the GMP branch CDecNumber and CFixedFloat both wrap Boost's  mpfr_float<0>  (or similar, I forgot the exact syntax) with precision dynamic at runtime.  So I call mpfr_float<0>::default_precision(digits10)  when I want to change the global precision (shared by both types), wrapping it in a class so it resets automatically when the Precision object goes out of scope and is destructed.  I also sometimes call the .precision(digitis10) method of particular variables when I need to change it.  There is also a .precision() getter method on the Boost types.

[knighty]

knighty I guess you compiled the 'claude' branch, any chance of instructions for the 'claude-gmp' branch too?  You need boost for the multiprecision wrappers (header-only afaik, at least I don't think I compiled boost) and GMP.  I'll update the Makefile to make it possible to set the windres program from the command line without editing.

Yes, that was the 'claude' branch. I've just compiled the 'claude-gmp' branch without any problem. I just had to download boost:

Code:

pacman -S mingw-w64-x86_64-boost

from msys shell, then after closing msys shell and opening mingw64 shell, compile KF (from its sources directory):

Code:

cd <directory of 'claude-gmp-kf'>
mingw32-make WINDRES=windres
mingw32-make clean

There are only some warnings (as with 'claude' branch)

In order to execute it from the explorer one needs to copy libgmp-10.dll and libwinpthread-1.dll from msys64/mingw64/bin next to the generated executable (kf.exe).

BTW: The list of available mingw packages is here.

[Kalles Fraktaler]

I just found an embarrasing bug, that have been there all the time.
In the file main.cpp, the small "cross-hair" window is not updated if the cursor is above the cross-hair window itself.
Then the message procedure is exited, however this check is done after GDI resources are loaded, so by holding the cursor over the cross-hair window for a long time all resources eventually runs out.
Beginning on line 1754, please move the condition and return up to just after the call to GetCursorPos, like this:

Code:

...
else if(uMsg==WM_TIMER){
POINT p;
GetCursorPos(&p);
if(hWnd==WindowFromPoint(p) || hWnd==GetParent(WindowFromPoint(p)))
return 0;
...

Sorry for that... 

[claude]

bug

Thanks for the fix!  I committed it to all 3 branches in my repository.

[claude]

I fixed some bugs (and Karl fixed one too).  And I made a page for the project, where you can download it: https://mathr.co.uk/kf/kf.html

This fix made it 90% faster for trivial zooms like the initial view: https://code.mathr.co.uk/kalles-fraktaler-2/commitdiff/d99f73c1cd4343dd2c2d627ef1d221dbfd916456

[Kalles Fraktaler]

I fixed some bugs (and Karl fixed one too).  And I made a page for the project, where you can download it: https://mathr.co.uk/kf/kf.html

This fix made it 90% faster for trivial zooms like the initial view: https://code.mathr.co.uk/kalles-fraktaler-2/commitdiff/d99f73c1cd4343dd2c2d627ef1d221dbfd916456

Cool, thanks!
I have put a link to your page in the top of my page, http://www.chillheimer.de/kallesfraktaler/
   

[Kalles Fraktaler]

This fix made it 90% faster for trivial zooms like the initial view: https://code.mathr.co.uk/kalles-fraktaler-2/commitdiff/d99f73c1cd4343dd2c2d627ef1d221dbfd916456

I don't understand what you fixed, is it about inflection?
That was an experiment I did, but it didn't get to work with perturbation.
I thought I had commented all of that away..?

[claude]

I put the inflection stuff behind an if, otherwise with no inflections it was still converting from double to CFixedFloat and back again without doing anything to the coordinates.  Maybe is a version mismatch?  I recommend git for version control (other systems are available) - handy for keeping track of changes.

[Kalles Fraktaler]

I made a comparison test.
I rendered stardust4ever's Magnum Opus Ex, http://stardust4ever.deviantart.com/art/Magnum-Opus-Ex-3132-6-Zooms-274474754, in 3200x3200.
My version of KF used 12m32s while your version used 3m37s, so the speed-up is 3.4 times, and amazingly more that 11,000 times faster than the original render by stardust!